nomadVar: return map values instead of pointers when reading map items#2133
Merged
pkazmierczak merged 1 commit intomainfrom Feb 23, 2026
Merged
nomadVar: return map values instead of pointers when reading map items#2133pkazmierczak merged 1 commit intomainfrom
pkazmierczak merged 1 commit intomainfrom
Conversation
krutibaraiya
approved these changes
Feb 17, 2026
Member
krutibaraiya
left a comment
krutibaraiya
left a comment
There was a problem hiding this comment.
The PR looks good from a Consul perspective to me. Doesn't look like the changes affect Consul. @santoshpulluri / @kswap could you also please take a final look to confirm? Thanks!
Contributor
Author
|
@santoshpulluri @kswap It's been a while and since we've already gotten 2 approvals I'm gonna go ahead and merge this. We can always revisit before the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nomad templates behave in unpredictable ways when parsing variables outside of
withblocks. See hashicorp/nomad#27455 for more context, but the gist of theissue is that Consul Template returns pointer values when parsing map items,
and it should instead always return map values.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.